Skip to content

cuid recent update breaks browserify#24

Open
panthershark wants to merge 1 commit into
Raynos:masterfrom
panthershark:master
Open

cuid recent update breaks browserify#24
panthershark wants to merge 1 commit into
Raynos:masterfrom
panthershark:master

Conversation

@panthershark

@panthershark panthershark commented Aug 25, 2015

Copy link
Copy Markdown

The cuid package was updated to 1.3.0 today with some kind of breaking change which it breaks the ability to browserify. I am running mercury.js for my build. This PR changes cuid dependency from caret to tilde so we can take the time to figure out why cuid breaks.

Would you accept this PR and publish a patch version of dom-delegator please?

events.js:141
      throw er; // Unhandled 'error' event
            ^
Error: Cannot find module 'cuid' from '/Users/tommy/src/cbanc/cbw/node_modules/mercury/node_modules/dom-delegator'
    at /Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:46:17
    at process (/Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:173:43)
    at ondir (/Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:188:17)
    at load (/Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
    at onex (/Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
    at /Users/tommy/src/cbanc/cbw/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
    at FSReqWrap.oncomplete (fs.js:82:15)

@panthershark

panthershark commented Aug 25, 2015

Copy link
Copy Markdown
Author

Looks like it is reported over here - paralleldrive/cuid#42

@ericelliott

ericelliott commented Aug 25, 2015

Copy link
Copy Markdown

cuid fix incoming.

@nikuda

nikuda commented Aug 25, 2015

Copy link
Copy Markdown

I'd suggest locking down all dom-delegator deps to patch versioning ~, or even better, have them all fixed to a version.

@ericelliott

ericelliott commented Aug 25, 2015

Copy link
Copy Markdown

Generally a good idea.

@panthershark

panthershark commented Aug 25, 2015

Copy link
Copy Markdown
Author

@nikuda - agree.

@ericelliot - thanks for being so responsive :)

@ericelliott

ericelliott commented Aug 25, 2015

Copy link
Copy Markdown

👍

@derhuerst derhuerst mentioned this pull request Mar 9, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@panthershark @ericelliott @nikuda